lennartandClaude Opus 5
46160d86dc
Fixes "Can't start dialogue: no Yarn Project has been configured." Cause, and it was mine. Phase 3.7 said "retarget YarnDemoSetup.cs or retire it"; I retargeted it. But that menu does not modify a scene — it builds one from scratch and calls SaveScene over its target. Pointing it at SC101_ConferenceHall.unity armed it at the real level, and running it replaced the scene with a bare Yarn demo: ten of fourteen roots gone, including the player, the lighting and the navmesh. The leftover Dialogue System prefab instance it left behind had no yarnProject override, auto-started, and produced the error. The scene was committed, so nothing was lost; it is restored from HEAD at 14 roots with its sun reference intact. The menu now targets Assets/Scenes/Dev/YarnSandbox.unity and refuses to run if its target is not under Scenes/Dev, via ScenePaths.IsDisposable. It is renamed to "Set Up Yarn Sandbox Scene" so the menu says what it does. The other three setup menus open and modify their target rather than regenerating it, so they were never affected and are unchanged. The test suite could not have caught this, because it asserted only that a DialogueRunner existed. TheDialogueRunner_HasItsYarnProject now asserts there is exactly one runner across the loaded scenes and that its project is set and compiled — which reproduces the failure exactly when the scene is broken. Also here: four UI prefabs pick up m_EditorClassIdentifier changes from Assembly-CSharp to NightclubArcadia.Game, written by Unity after the assembly split in the previous commit. Expected and correct. EditMode 42/42, PlayMode 6/6, YarnCheck 9 files / 35 nodes. Co-Authored-By: Claude Opus 5 <[email protected]>
97 lines
3.5 KiB
C#
97 lines
3.5 KiB
C#
using UnityEditor;
|
|
using UnityEditor.SceneManagement;
|
|
using UnityEngine;
|
|
using UnityEngine.EventSystems;
|
|
using Yarn.Compiler;
|
|
using Yarn.Unity;
|
|
using Yarn.Unity.Editor;
|
|
|
|
public static class YarnDemoSetup
|
|
{
|
|
const string YarnProjectPath = "Assets/Dialogue/NightclubArcadia.yarnproject";
|
|
const string ScenePath = NightclubArcadia.EditorTools.ScenePaths.Sandbox;
|
|
|
|
[MenuItem("Tools/Nightclub Arcadia/Set Up Yarn Sandbox Scene")]
|
|
public static void SetUpYarnDialogueTest()
|
|
{
|
|
// This menu BUILDS A SCENE FROM SCRATCH and saves over ScenePath. Pointed at a
|
|
// real level it silently destroys it, which is exactly what happened when it
|
|
// was briefly retargeted at SC101_ConferenceHall. The guard is the fix; do not
|
|
// remove it, and do not point ScenePath outside Scenes/Dev.
|
|
if (!NightclubArcadia.EditorTools.ScenePaths.IsDisposable(ScenePath))
|
|
{
|
|
Debug.LogError($"Refusing to run: '{ScenePath}' is not under Assets/Scenes/Dev/. " +
|
|
"This menu overwrites its target scene wholesale.");
|
|
return;
|
|
}
|
|
|
|
if (!AssetDatabase.IsValidFolder("Assets/Scenes/Dev"))
|
|
{
|
|
AssetDatabase.CreateFolder("Assets/Scenes", "Dev");
|
|
}
|
|
|
|
if (!AssetDatabase.IsValidFolder("Assets/TextMesh Pro"))
|
|
{
|
|
Debug.LogWarning("TextMesh Pro essential resources are missing. Run Window → TextMeshPro → Import TMP Essential Resources.");
|
|
}
|
|
|
|
if (!AssetDatabase.IsValidFolder("Assets/Dialogue"))
|
|
{
|
|
AssetDatabase.CreateFolder("Assets", "Dialogue");
|
|
}
|
|
|
|
if (!AssetDatabase.IsValidFolder("Assets/Scenes"))
|
|
{
|
|
AssetDatabase.CreateFolder("Assets", "Scenes");
|
|
}
|
|
|
|
var yarnProject = AssetDatabase.LoadAssetAtPath<YarnProject>(YarnProjectPath);
|
|
if (yarnProject == null)
|
|
{
|
|
// YarnProjectUtility.CreateDefaultYarnProject is internal, so
|
|
// construct the same default project here.
|
|
var project = new Project
|
|
{
|
|
ExcludeFilePatterns = new[] { "**/*~/*", "./Samples/Yarn Spinner*/*" },
|
|
};
|
|
YarnEditorUtility.CreateYarnProject(YarnProjectPath, project);
|
|
AssetDatabase.Refresh();
|
|
yarnProject = AssetDatabase.LoadAssetAtPath<YarnProject>(YarnProjectPath);
|
|
}
|
|
|
|
var scene = EditorSceneManager.NewScene(NewSceneSetup.DefaultGameObjects, NewSceneMode.Single);
|
|
|
|
var runner = CreateDialogueRunnerMenuItem.CreateDialogueRunner();
|
|
|
|
var so = new SerializedObject(runner);
|
|
so.FindProperty("yarnProject").objectReferenceValue = yarnProject;
|
|
so.ApplyModifiedPropertiesWithoutUndo();
|
|
|
|
runner.autoStart = true;
|
|
runner.startNode = "Start";
|
|
EditorUtility.SetDirty(runner);
|
|
|
|
#if UNITY_2023_1_OR_NEWER
|
|
var eventSystems = Object.FindObjectsByType<EventSystem>(FindObjectsInactive.Include);
|
|
#else
|
|
var eventSystems = Object.FindObjectsOfType<EventSystem>(true);
|
|
#endif
|
|
foreach (var eventSystem in eventSystems)
|
|
{
|
|
if (eventSystem.GetComponent<BaseInputModule>() != null)
|
|
{
|
|
continue;
|
|
}
|
|
|
|
#if ENABLE_INPUT_SYSTEM
|
|
eventSystem.gameObject.AddComponent<UnityEngine.InputSystem.UI.InputSystemUIInputModule>();
|
|
#endif
|
|
}
|
|
|
|
EditorSceneManager.SaveScene(scene, ScenePath);
|
|
AssetDatabase.SaveAssets();
|
|
|
|
Debug.Log($"Yarn dialogue test setup complete. Scene saved to {ScenePath}");
|
|
}
|
|
}
|